review-verification-protocol

Review Verification Protocol

This protocol MUST be followed before reporting any code review finding. Skipping these steps leads to false positives that waste developer time and erode trust in reviews.

Hard gates (sequence)

Complete gates in order for each finding (or finding class). A gate passes only when the pass condition is objectively met—internal confidence is not enough.

1. Read scope — PASS when: You cite the full enclosing unit you judged (e.g. function, method, or class): file path plus start–end line range or symbol name. Diff-only context without full-unit read fails this gate.
2. Reference check (required for “unused”, “dead code”, “orphaned export”, “never called”) — PASS when: You ran a workspace-wide search for the symbol (ripgrep, IDE references, or find_referencing_symbols-style lookup) and noted whether non-definition matches exist. If use may be dynamic (decorators, getattr, entry points, plugins), PASS when: you state that and name the registration or import path that could justify the symbol.
3. Upstream / downstream (required for “missing validation”, “no error handling”, “race”, “leak”) — PASS when: You checked at least one of: caller, route/middleware, parent task, framework hook, or lifecycle (e.g. teardown, signal), and recorded whether responsibility already sits there.
4. Evidence line — PASS when: The finding includes [FILE:LINE] to the line that shows the issue (same requirement as Before Submitting Review).

If any gate fails, do not report the issue; gather evidence or drop it.

Pre-Report Verification Checklist

Before flagging ANY issue, verify (after Hard gates above):

• [ ] I read the actual code - Not just the diff context, but the full function/class
• [ ] I searched for usages - Before claiming "unused", searched all references
• [ ] I checked surrounding code - The issue may be handled elsewhere (guards, earlier checks)
• [ ] I verified syntax against current docs - Framework syntax evolves (Tailwind v4, TS 5.x, React 19)
• [ ] I distinguished "wrong" from "different style" - Both approaches may be valid
• [ ] I considered intentional design - Checked comments, CLAUDE.md, architectural context

Verification by Issue Type

"Unused Variable/Function"

Before flagging, you MUST:

1. Search for ALL references in the codebase (grep/find)
2. Check if it's exported and used by external consumers
3. Check if it's used via reflection, decorators, or dynamic dispatch
4. Verify it's not a callback passed to a framework

Common false positives:

• State setters in React (may trigger re-renders even if value appears unused)
• Variables used in templates/JSX
• Exports used by consuming packages

"Missing Validation/Error Handling"

Before flagging, you MUST:

1. Check if validation exists at a higher level (caller, middleware, route handler)
2. Check if the framework provides validation (Pydantic, Zod, TypeScript)
3. Verify the "missing" check isn't present in a different form

Common false positives:

• Framework already validates (FastAPI + Pydantic, React Hook Form)
• Parent component validates before passing props
• Error boundary catches at higher level

"Type Assertion/Unsafe Cast"

Before flagging, you MUST:

1. Confirm it's actually an assertion, not an annotation
2. Check if the type is narrowed by runtime checks before the point
3. Verify if framework guarantees the type (loader data, form data)

Valid patterns often flagged incorrectly:

# Type annotation, NOT cast
data: UserData = await load_user()

# Type narrowing with isinstance
if isinstance(data, User):
    data.name  # Mypy knows this is User

"Potential Memory Leak/Race Condition"

Before flagging, you MUST:

1. Verify cleanup function is actually missing (not just in a different location)
2. Check if AbortController signal is checked after awaits
3. Confirm the component can actually unmount during the async operation

Common false positives:

• Cleanup exists in useEffect return
• Signal is checked (code reviewer missed it)
• Operation completes before unmount is possible

"Performance Issue"

Before flagging, you MUST:

1. Confirm the code runs frequently enough to matter (render vs click handler)
2. Verify the optimization would have measurable impact
3. Check if the framework already optimizes this (React compiler, memoization)

Do NOT flag:

• Functions created in click handlers (runs once per click)
• Array methods on small arrays (< 100 items)
• Object creation in event handlers

Severity Calibration

Critical (Block Merge)

ONLY use for:

• Security vulnerabilities (injection, auth bypass, data exposure)
• Data corruption bugs
• Crash-causing bugs in happy path
• Breaking changes to public APIs

Major (Should Fix)

Use for:

• Logic bugs that affect functionality
• Missing error handling that causes poor UX
• Performance issues with measurable impact
• Accessibility violations

Minor (Consider Fixing)

Use for:

• Code clarity improvements
• Documentation gaps
• Inconsistent style (within reason)
• Non-critical test coverage gaps

Informational (No Action Required)

Use for:

• Improvements that require adding new dependencies or modules
• Suggestions for net-new code that didn't exist in the codebase before (new modules, test suites, abstractions)
• Architectural ideas for future consideration
• Test infrastructure suggestions (new mock libraries, behaviour extraction)
• Optimizations without measurable impact in the current context

These are NOT review blockers. They should be noted for the author's awareness but must not appear in the actionable issue count. The Verdict should ignore informational items entirely.

Do NOT Flag At All

• Style preferences where both approaches are valid
• Optimizations with no measurable benefit
• Test code not meeting production standards (intentionally simpler)
• Library/framework internal code (shadcn components, generated code)
• Hypothetical issues that require unlikely conditions

Valid Patterns (Do NOT Flag)

Python

| Pattern | Why It's Valid | |---------|----------------| | dict.get(key, []) | Returns default for missing keys, not error suppression | | Optional[T] return type | Standard way to express nullable in Python typing | | assert in test code | pytest uses assertions, not try/except | | Type annotation on variable | Not a cast, just a hint for type checkers | | typing.cast() with prior validation | Valid after runtime check confirms type |

FastAPI

| Pattern | Why It's Valid | |---------|----------------| | Depends() without explicit type | FastAPI infers dependency type from function signature | | async def endpoint without await | May use sync DB calls or simple returns | | Response model different from DB model | Separation of concerns between API and persistence | | BackgroundTasks parameter | Valid for fire-and-forget operations | | Direct request.state access | Standard pattern for middleware-injected data |

Testing

| Pattern | Why It's Valid | |---------|----------------| | assert without message | pytest rewrites assertions to show detailed diffs | | @pytest.fixture without explicit scope | Default function scope is correct for most fixtures | | monkeypatch over unittest.mock | Simpler API, pytest-native | | Fixture returning mutable state | Each test gets fresh fixture invocation by default |

General

| Pattern | Why It's Valid | |---------|----------------| | +? lazy quantifier in regex | Prevents over-matching, correct for many patterns | | Direct string concatenation | Simpler than template literals for simple cases | | Multiple returns in function | Can improve readability | | Comments explaining "why" | Better than no comments |

Context-Sensitive Rules

Type Annotations

Flag missing type annotati